abhishekagarwal87 commented on a change in pull request #11530:
URL: https://github.com/apache/druid/pull/11530#discussion_r680706056
##########
File path: docs/configuration/index.md
##########
@@ -1605,7 +1605,8 @@ These Broker configurations can be defined in the
`broker/runtime.properties` fi
|--------|---------------|-----------|-------|
|`druid.broker.balancer.type`|`random`, `connectionCount`|Determines how the
broker balances connections to Historical processes. `random` choose randomly,
`connectionCount` picks the process with the fewest number of active
connections to|`random`|
|`druid.broker.select.tier`|`highestPriority`, `lowestPriority`, `custom`|If
segments are cross-replicated across tiers in a cluster, you can tell the
broker to prefer to select segments in a tier with a certain
priority.|`highestPriority`|
-|`druid.broker.select.tier.custom.priorities`|`An array of integer
priorities.` E.g., `[-1, 0, 1, 2]`|Select servers in tiers with a custom
priority list.|The config only has effect if `druid.broker.select.tier` is set
to `custom`. If `druid.broker.select.tier` is set to `custom` but this config
is not specified, the effect is the same as `druid.broker.select.tier` set to
`highestPriority`. Any of the integers in this config can be ignored if there's
no corresponding tiers with such priorities. Tiers with priorities explicitly
specified in this config always have higher priority than those not and those
not specified fall back to use `highestPriority` strategy among themselves.|
+|`druid.broker.select.tier.custom.priorities`|An array of integer priorities.
E.g., `[-1, 0, 1, 2]`|Select servers in tiers with a custom priority list.|The
config only has effect if `druid.broker.select.tier` is set to `custom`. If
`druid.broker.select.tier` is set to `custom` but this config is not specified,
the effect is the same as `druid.broker.select.tier` set to `highestPriority`.
Any of the integers in this config can be ignored if there's no corresponding
tiers with such priorities. Tiers with priorities explicitly specified in this
config always have higher priority than those not and those not specified fall
back to use `highestPriority` strategy among themselves.|
+|`druid.broker.select.tier.custom.tierNames`|A non-empty array of tier names,
e.g., `["_default_tier","_hot_tier"]`|Specifies the tier names to which the
Broker can connect. The Broker cannot connect to a Historical process belonging
to a tier not listed in this config.|All tiers are allowed if no value is
specified for this config or if an empty array is specified. This config has
effect only if `druid.broker.select.tier` is set to `custom`.|
Review comment:
```suggestion
|`druid.broker.select.tier.custom.allowedTierNames`|A non-empty array of
tier names, e.g., `["_default_tier","_hot_tier"]`|Specifies the tier names to
which the Broker can connect. The Broker cannot connect to a Historical process
belonging to a tier not listed in this config.|All tiers are allowed if no
value is specified for this config or if an empty array is specified. This
config has effect only if `druid.broker.select.tier` is set to `custom`.|`[]`|
```
##########
File path:
server/src/main/java/org/apache/druid/client/selector/CustomTierSelectorStrategyConfig.java
##########
@@ -31,8 +31,16 @@
@JsonProperty
private List<Integer> priorities = new ArrayList<>();
+ @JsonProperty
+ private List<String> allowedTiers = new ArrayList<>();
Review comment:
this name should be same as what comes after
`druid.broker.select.tier.custom.`. so if you are using
`druid.broker.select.tier.custom.tierNames`, then this field should be named
`tierNames` or you should have the annotation as `@JsonProperty("tierNames")`
Please add a test for serde if not added already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
