zachjsh commented on pull request #11507:
URL: https://github.com/apache/druid/pull/11507#issuecomment-891300191


   > @zachjsh I want to get this in as soon as possible I added few tests and 
was adding more but need some clarification on 
[this](https://github.com/apache/druid/pull/11507#issuecomment-891161308). My 
email is pjain1[at]apache[dot]org. Once things are clear I can add unit tests 
that should not take much time, I am not familiar with IT test framework so 
that may take some time so overall targeting it to finish this week.
   
   Thanks for your quick reply @pjain1. Happy to hear that you are trying to 
get this in as soon as possible. Will work with you through any  doubts or 
uncertainties that you have. Will let @jihoonson reply to the comment that you 
linked in your previous message. As for adding an Integration test for this. I 
think that ITPerfectRollupParallelIndexTest is a good example test to base this 
after, or extend.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to