zachjsh commented on a change in pull request #11507:
URL: https://github.com/apache/druid/pull/11507#discussion_r681255002
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/GenericPartitionLocation.java
##########
@@ -22,15 +22,26 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
+import org.apache.druid.java.util.common.StringUtils;
import org.apache.druid.timeline.partition.BuildingShardSpec;
import org.joda.time.Interval;
+import java.net.URI;
+import java.util.Objects;
+
/**
* This class represents the intermediary data server where the partition of
{@code interval} and {@code shardSpec}
* is stored.
*/
-public class GenericPartitionLocation extends
PartitionLocation<BuildingShardSpec>
+public class GenericPartitionLocation implements
PartitionLocation<BuildingShardSpec>
Review comment:
please add unit tests for the code added here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
