jihoonson commented on a change in pull request #11553:
URL: https://github.com/apache/druid/pull/11553#discussion_r683602732
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexPhaseRunner.java
##########
@@ -289,13 +289,15 @@ private void stopInternal()
@Override
public void collectReport(SubTaskReportType report)
{
- taskMonitor.collectReport(report);
+ if (taskMonitor != null) {
+ taskMonitor.collectReport(report);
+ }
Review comment:
`collectReport` should be called only when there is a subtask sending
its report. Since `TaskMonitor` is responsible for spawning subtasks, it seems
quite strange if `taskMonitor` is null when this method is called. How about
adding a precondition that explodes when it's null?
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexPhaseRunner.java
##########
@@ -289,13 +289,15 @@ private void stopInternal()
@Override
public void collectReport(SubTaskReportType report)
{
- taskMonitor.collectReport(report);
+ if (taskMonitor != null) {
+ taskMonitor.collectReport(report);
+ }
}
@Override
public Map<String, SubTaskReportType> getReports()
{
- return taskMonitor.getReports();
+ return taskMonitor == null ? Collections.emptyMap() :
taskMonitor.getReports();
Review comment:
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
