jihoonson commented on a change in pull request #11553:
URL: https://github.com/apache/druid/pull/11553#discussion_r683613297
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexPhaseRunner.java
##########
@@ -289,13 +289,15 @@ private void stopInternal()
@Override
public void collectReport(SubTaskReportType report)
{
- taskMonitor.collectReport(report);
+ if (taskMonitor != null) {
+ taskMonitor.collectReport(report);
+ }
Review comment:
The comment sounds good. I think having a null check is also a good
convention because someone like me could break the contract around
`taskMonitor` unintentionally in the future. Perhaps we can add `assert
taskMonitor != null;`. This will be ran only in tests, but not in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
