loquisgon commented on a change in pull request #11536:
URL: https://github.com/apache/druid/pull/11536#discussion_r686443280
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/BatchAppenderator.java
##########
@@ -110,20 +113,28 @@
private final ObjectMapper objectMapper;
private final IndexIO indexIO;
private final IndexMerger indexMerger;
- private final Map<SegmentIdWithShardSpec, Sink> sinks = new HashMap<>();
private final long maxBytesTuningConfig;
private final boolean skipBytesInMemoryOverheadCheck;
+ private volatile ListeningExecutorService persistExecutor = null;
+ private volatile ListeningExecutorService pushExecutor = null;
+ private final int maxPendingPersists;
+ private static final int DEFAULT_PENDING_PERSISTS = 2;
+ private static final int PERSIST_WARN_DELAY = 1000;
+ private volatile Throwable persistError;
+
+
+ private final ConcurrentHashMap<SegmentIdWithShardSpec, Sink> sinks = new
ConcurrentHashMap<>();
/**
* The following sinks metadata map and associated class are the way to
retain metadata now that sinks
* are being completely removed from memory after each incremental persist.
*/
- private final Map<SegmentIdWithShardSpec, SinkMetadata> sinksMetadata = new
HashMap<>();
+ private final ConcurrentHashMap<SegmentIdWithShardSpec, SinkMetadata>
sinksMetadata = new ConcurrentHashMap<>();
Review comment:
Added comments about the usage for this in the javadoc (next commit)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
