loquisgon commented on a change in pull request #11536:
URL: https://github.com/apache/druid/pull/11536#discussion_r702198963
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/appenderator/UnifiedIndexerAppenderatorsManager.java
##########
@@ -227,8 +226,81 @@ public Appenderator createOfflineAppenderatorForTask(
indexIO,
wrapIndexMerger(indexMerger),
rowIngestionMeters,
- parseExceptionHandler,
- useLegacyBatchProcessing
+ parseExceptionHandler
+ );
+ datasourceBundle.addAppenderator(taskId, appenderator);
+ return appenderator;
+ }
+ }
+
+ @Override
+ public Appenderator createLegacyOfflineAppenderatorForTask(
+ String taskId,
+ DataSchema schema,
+ AppenderatorConfig config,
+ FireDepartmentMetrics metrics,
+ DataSegmentPusher dataSegmentPusher,
+ ObjectMapper objectMapper,
+ IndexIO indexIO,
+ IndexMerger indexMerger,
+ RowIngestionMeters rowIngestionMeters,
+ ParseExceptionHandler parseExceptionHandler
+ )
+ {
+ synchronized (this) {
+ DatasourceBundle datasourceBundle = datasourceBundles.computeIfAbsent(
+ schema.getDataSource(),
+ DatasourceBundle::new
+ );
+
+ Appenderator appenderator = Appenderators.createLegacyOffline(
+ taskId,
+ schema,
+ rewriteAppenderatorConfigMemoryLimits(config),
+ metrics,
+ dataSegmentPusher,
+ objectMapper,
+ indexIO,
+ wrapIndexMerger(indexMerger),
+ rowIngestionMeters,
+ parseExceptionHandler
+ );
+ datasourceBundle.addAppenderator(taskId, appenderator);
+ return appenderator;
+ }
+ }
+
+ @Override
+ public Appenderator createClosedSegmentsOfflineAppenderatorForTask(
+ String taskId,
+ DataSchema schema,
+ AppenderatorConfig config,
+ FireDepartmentMetrics metrics,
+ DataSegmentPusher dataSegmentPusher,
+ ObjectMapper objectMapper,
+ IndexIO indexIO,
+ IndexMerger indexMerger,
+ RowIngestionMeters rowIngestionMeters,
+ ParseExceptionHandler parseExceptionHandler
+ )
+ {
+ synchronized (this) {
+ DatasourceBundle datasourceBundle = datasourceBundles.computeIfAbsent(
+ schema.getDataSource(),
+ DatasourceBundle::new
+ );
+
+ Appenderator appenderator = Appenderators.createLegacyOffline(
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
