clintropolis commented on a change in pull request #11608:
URL: https://github.com/apache/druid/pull/11608#discussion_r690759456
##########
File path: docs/development/extensions-core/druid-lookups.md
##########
@@ -31,12 +31,12 @@ The main goal of this cache is to speed up the access to a
high latency lookup s
Thus user can define various caching strategies or and implementation per
lookup, even if the source is the same.
This module can be used side to side with other lookup module like the global
cached lookup module.
-To use this extension please make sure to
[include](../../development/extensions.md#loading-extensions)
`druid-lookups-cached-single` as an extension.
+To use this extension please make sure to
[include](../extensions.md#loading-extensions) `druid-lookups-cached-single` as
an extension.
Review comment:
should this be something like
>... include `druid-lookups-cached-single` in the extension load list.
so it isn't
> this extension ... as an extension.
?
##########
File path: docs/development/extensions-core/druid-lookups.md
##########
@@ -31,12 +31,12 @@ The main goal of this cache is to speed up the access to a
high latency lookup s
Thus user can define various caching strategies or and implementation per
lookup, even if the source is the same.
This module can be used side to side with other lookup module like the global
cached lookup module.
-To use this extension please make sure to
[include](../../development/extensions.md#loading-extensions)
`druid-lookups-cached-single` as an extension.
+To use this extension please make sure to
[include](../extensions.md#loading-extensions) `druid-lookups-cached-single` as
an extension.
Review comment:
should this be something like
>... include `druid-lookups-cached-single` in the extension load list.
so it isn't
> this extension ... as an extension.
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
