techdocsmith commented on a change in pull request #11608: URL: https://github.com/apache/druid/pull/11608#discussion_r690670167
########## File path: docs/development/extensions-core/lookups-cached-global.md ########## @@ -370,7 +370,7 @@ The JDBC lookups will poll a database to populate its local cache. If the `tsCol > If using JDBC, you will need to add your database's client JAR files to the > extension's directory. > For Postgres, the connector JAR is already included. -> For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/. +> See the MySQL extension documentation for instructions on how to obtain for [MySQL](./mysql.md#installing-the-mysql-connector-library) or [MariaDB](./mysql.md#alternative-installing-the-mariadb-connector-library) connector libraries. Review comment: ```suggestion > See the MySQL extension documentation for instructions to obtain [MySQL](./mysql.md#installing-the-mysql-connector-library) or [MariaDB](./mysql.md#alternative-installing-the-mariadb-connector-library) connector libraries. ``` ########## File path: docs/development/extensions-core/druid-lookups.md ########## @@ -31,12 +31,12 @@ The main goal of this cache is to speed up the access to a high latency lookup s Thus user can define various caching strategies or and implementation per lookup, even if the source is the same. This module can be used side to side with other lookup module like the global cached lookup module. -To use this extension please make sure to [include](../../development/extensions.md#loading-extensions) `druid-lookups-cached-single` as an extension. +To use this extension please make sure to [include](../extensions.md#loading-extensions) `druid-lookups-cached-single` as an extension. > If using JDBC, you will need to add your database's client JAR files to the > extension's directory. > For Postgres, the connector JAR is already included. -> For MySQL, you can get it from https://dev.mysql.com/downloads/connector/j/. -> Copy or symlink the downloaded file inside the folder `extensions/druid-lookups-cached-single` under the distribution root directory. +> See the MySQL extension documentation for instructions on how to obtain for [MySQL](./mysql.md#installing-the-mysql-connector-library) or [MariaDB](./mysql.md#alternative-installing-the-mariadb-connector-library) connector libraries. Review comment: ```suggestion > See the MySQL extension documentation for instructions to obtain [MySQL](./mysql.md#installing-the-mysql-connector-library) or [MariaDB](./mysql.md#alternative-installing-the-mariadb-connector-library) connector libraries. ``` ########## File path: docs/development/extensions-core/mysql.md ########## @@ -87,6 +102,8 @@ Copy or symlink this file inside the folder `extensions/mysql-metadata-storage` druid.metadata.storage.connector.password=diurd ``` +If using MariaDB, `druid.metadata.mysql.driver.driverClassName=org.mariadb.jdbc.Driver` must also be set. Review comment: ```suggestion If using MariaDB, set `druid.metadata.mysql.driver.driverClassName=org.mariadb.jdbc.Driver`. ``` ########## File path: docs/development/extensions-core/mysql.md ########## @@ -51,7 +64,9 @@ Copy or symlink this file inside the folder `extensions/mysql-metadata-storage` Alternatively, download and follow installation instructions for MySQL Community Server here: - [http://dev.mysql.com/downloads/mysql/](http://dev.mysql.com/downloads/mysql/) + [http://dev.mysql.com/downloads/mysql/](http://dev.mysql.com/downloads/mysql/). + +This extension should also function correctly using MariaDB server, https://mariadb.org/download/, substituting for MariaDB in the following instructions where appropriate. Review comment: ```suggestion This extension should also supports MariaDB server, https://mariadb.org/download/, substituting for MariaDB in the following instructions where appropriate. ``` ########## File path: docs/development/extensions-core/druid-lookups.md ########## @@ -31,12 +31,12 @@ The main goal of this cache is to speed up the access to a high latency lookup s Thus user can define various caching strategies or and implementation per lookup, even if the source is the same. This module can be used side to side with other lookup module like the global cached lookup module. -To use this extension please make sure to [include](../../development/extensions.md#loading-extensions) `druid-lookups-cached-single` as an extension. +To use this extension please make sure to [include](../extensions.md#loading-extensions) `druid-lookups-cached-single` as an extension. Review comment: ```suggestion To use this extension [include](../extensions.md#loading-extensions) `druid-lookups-cached-single` as an extension. ``` ########## File path: docs/development/extensions-core/mysql.md ########## @@ -41,6 +41,19 @@ This should fetch a JAR file named similar to 'mysql-connector-java-x.x.xx.jar'. Copy or symlink this file inside the folder `extensions/mysql-metadata-storage` under the distribution root directory. +## Alternative: Installing the MariaDB connector library + +THis extension also supports using the MariaDB connector jar, though it is also not included in the Druid distribution and must be installed separately like the MySQL connector. Review comment: ```suggestion This extension also supports using the MariaDB connector jar. The MariaDB connector is not included in the Druid distribution, so you must install it separately. ``` ########## File path: docs/development/extensions-core/mysql.md ########## @@ -25,12 +25,12 @@ title: "MySQL Metadata Store" To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `mysql-metadata-storage` as an extension. -> The MySQL extension requires the MySQL Connector/J library which is not included in the Druid distribution. +> The MySQL extension requires the MySQL Connector/J library or MariaDB Connector/J library, neither of which is not included in the Druid distribution. > Refer to the following section for instructions on how to install this > library. ## Installing the MySQL connector library -This extension uses Oracle's MySQL JDBC driver which is not included in the Druid distribution and must be +This extension can use Oracle's MySQL JDBC driver which is not included in the Druid distribution and must be installed separately. There are a few ways to obtain this library: Review comment: ```suggestion install it separately. There are a few ways to obtain this library: ``` ########## File path: docs/development/extensions-core/mysql.md ########## @@ -25,12 +25,12 @@ title: "MySQL Metadata Store" To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `mysql-metadata-storage` as an extension. -> The MySQL extension requires the MySQL Connector/J library which is not included in the Druid distribution. +> The MySQL extension requires the MySQL Connector/J library or MariaDB Connector/J library, neither of which is not included in the Druid distribution. Review comment: ```suggestion > The MySQL extension requires the MySQL Connector/J library or MariaDB Connector/J library, neither of which are included in the Druid distribution. ``` Double negative. Looks like neither are included. ########## File path: docs/development/extensions-core/mysql.md ########## @@ -41,6 +41,19 @@ This should fetch a JAR file named similar to 'mysql-connector-java-x.x.xx.jar'. Copy or symlink this file inside the folder `extensions/mysql-metadata-storage` under the distribution root directory. +## Alternative: Installing the MariaDB connector library + +THis extension also supports using the MariaDB connector jar, though it is also not included in the Druid distribution and must be installed separately like the MySQL connector. + +- Download from the MariaDB site: https://mariadb.com/downloads/connector +- Maven Central: https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/2.7.3/mariadb-java-client-2.7.3.jar Review comment: ```suggestion - Download from Maven Central: https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/2.7.3/mariadb-java-client-2.7.3.jar ``` ########## File path: docs/development/extensions-core/mysql.md ########## @@ -41,6 +41,19 @@ This should fetch a JAR file named similar to 'mysql-connector-java-x.x.xx.jar'. Copy or symlink this file inside the folder `extensions/mysql-metadata-storage` under the distribution root directory. +## Alternative: Installing the MariaDB connector library + +THis extension also supports using the MariaDB connector jar, though it is also not included in the Druid distribution and must be installed separately like the MySQL connector. + +- Download from the MariaDB site: https://mariadb.com/downloads/connector +- Maven Central: https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/2.7.3/mariadb-java-client-2.7.3.jar + +This should fetch a JAR file named similar to 'maria-java-client-x.x.x.jar'. + +Copy or symlink this file to `extensions/mysql-metadata-storage` under the distribution root directory. + +In Druid properties, `druid.metadata.mysql.driver.driverClassName=org.mariadb.jdbc.Driver` must be set, which will instruct the `mysql-metadata-storage` extension to use the MariaDB connector library instead of MySQL. Depending on the MariaDB client library version, it will support both `jdbc:mysql:` and `jdbc:mariadb:` connection URIs, though the parameters to configure the connection vary between implementations, so be sure to [check the documentation](https://mariadb.com/kb/en/about-mariadb-connector-j/#connection-strings) for details. Review comment: ```suggestion To configure the `mysql-metadata-storage` extension to use the MariaDB connector library instead of MySQL, set the following in the Druid properties: `druid.metadata.mysql.driver.driverClassName=org.mariadb.jdbc.Driver` Depending on the MariaDB client library version, the connector supports both `jdbc:mysql:` and `jdbc:mariadb:` connection URIs. However, the parameters to configure the connection vary between implementations, so be sure to [check the documentation](https://mariadb.com/kb/en/about-mariadb-connector-j/#connection-strings) for details. ``` ########## File path: docs/development/extensions-core/mysql.md ########## @@ -25,12 +25,12 @@ title: "MySQL Metadata Store" To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `mysql-metadata-storage` as an extension. -> The MySQL extension requires the MySQL Connector/J library which is not included in the Druid distribution. +> The MySQL extension requires the MySQL Connector/J library or MariaDB Connector/J library, neither of which is not included in the Druid distribution. > Refer to the following section for instructions on how to install this > library. ## Installing the MySQL connector library -This extension uses Oracle's MySQL JDBC driver which is not included in the Druid distribution and must be +This extension can use Oracle's MySQL JDBC driver which is not included in the Druid distribution and must be Review comment: ```suggestion This extension can use Oracle's MySQL JDBC driver which is not included in the Druid distribution. You must``` ########## File path: docs/development/extensions-core/lookups-cached-global.md ########## @@ -25,7 +25,7 @@ title: "Globally Cached Lookups" > Lookups are an [experimental](../experimental.md) feature. -To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-lookups-cached-global` as an extension. +To use this Apache Druid extension, make sure to [include](../extensions.md#loading-extensions) `druid-lookups-cached-global` as an extension. Review comment: ```suggestion To use this Apache Druid extension, [include](../extensions.md#loading-extensions) `druid-lookups-cached-global` as an extension. ``` ########## File path: docs/development/extensions-core/mysql.md ########## @@ -41,6 +41,19 @@ This should fetch a JAR file named similar to 'mysql-connector-java-x.x.xx.jar'. Copy or symlink this file inside the folder `extensions/mysql-metadata-storage` under the distribution root directory. +## Alternative: Installing the MariaDB connector library + +THis extension also supports using the MariaDB connector jar, though it is also not included in the Druid distribution and must be installed separately like the MySQL connector. + +- Download from the MariaDB site: https://mariadb.com/downloads/connector +- Maven Central: https://repo1.maven.org/maven2/org/mariadb/jdbc/mariadb-java-client/2.7.3/mariadb-java-client-2.7.3.jar + +This should fetch a JAR file named similar to 'maria-java-client-x.x.x.jar'. Review comment: ```suggestion This fetches the MariaDB connector JAR file with a name like 'maria-java-client-x.x.x.jar'. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
