techdocsmith commented on a change in pull request #11463:
URL: https://github.com/apache/druid/pull/11463#discussion_r694301539



##########
File path: docs/tutorials/docker.md
##########
@@ -21,67 +21,108 @@ title: "Docker"
   ~ specific language governing permissions and limitations
   ~ under the License.
   -->
-  
+
 In this quickstart, we will download the Apache Druid image from [Docker 
Hub](https://hub.docker.com/r/apache/druid) and set it up on a single machine 
using [Docker](https://www.docker.com/get-started) and [Docker 
Compose](https://docs.docker.com/compose/). The cluster will be ready to load 
data after completing this initial setup.
 
-Before beginning the quickstart, it is helpful to read the [general Druid 
overview](../design/index.md) and the [ingestion 
overview](../ingestion/index.md), as the tutorials will refer to concepts 
discussed on those pages. Additionally, familiarity with Docker is recommended.
+Before beginning the quickstart, it is helpful to read the [general Druid 
overview](../design/index.md) and the [ingestion 
overview](../ingestion/index.md), as the tutorials will refer to concepts 
discussed on those pages. Additionally, familiarity with 
[Docker](https://www.docker.com/get-started) is recommended.
+
+This tutorial assumes you will download the required files from GitHub. The 
files are also available in a Druid installation and in the Druid sources.
 
 ## Prerequisites
 
-* Docker
+* [Docker](https://www.docker.com/get-started)
 
 ## Getting started
 
-The Druid source code contains [an example 
`docker-compose.yml`](https://github.com/apache/druid/blob/{{DRUIDVERSION}}/distribution/docker/docker-compose.yml)
 which can pull an image from Docker Hub and is suited to be used as an example 
environment and to experiment with Docker based Druid configuration and 
deployments.
+Create a directory to hold the Druid Docker files.
+
+The Druid source code contains [an example 
`docker-compose.yml`](https://github.com/apache/druid/blob/{{DRUIDVERSION}}/distribution/docker/docker-compose.yml)
 which pulls an image from Docker Hub and is suited to be used as an example 
environment and to experiment with Docker based Druid configuration and 
deployments. 
[Download](https://raw.githubusercontent.com/apache/druid/{{DRUIDVERSION}}/distribution/docker/docker-compose.yml)
 this file to the directory created above.
 
 ### Compose file
 
-The example `docker-compose.yml` will create a container for each Druid 
service, as well as ZooKeeper and a PostgreSQL container as the metadata store. 
+The example `docker-compose.yml` will create a container for each Druid 
service, as well as ZooKeeper and a PostgreSQL container as the metadata store.
 
-It will also create a named volumes `druid_shared`, which is mounted as 
`opt/shared` in container, as deep storage to keep and share segments and task 
logs among Druid services.
+It will also create a named volume `druid_shared` as deep storage to keep and 
share segments and task logs among Druid services. The volume is mounted as 
`opt/shared` in the container.
 
-The Druid containers are configured via an [environment 
file](https://github.com/apache/druid/blob/{{DRUIDVERSION}}/distribution/docker/environment).
+### Environment file
+
+The Druid `docker-compose.yml` example utilizes an [environment 
file](https://docs.docker.com/compose/environment-variables/#the-env_file-configuration-option)
 to specify the complete Druid configuration, including the environment 
variables listed below. This file is named `environment` by default, and must 
be in the same directory as the `docker-compose.yml` file. 
[Download](https://raw.githubusercontent.com/apache/druid/{{DRUIDVERSION}}/distribution/docker/environment)
 the example `environment` file to the directory created above. The options in 
this file work well for trying Druid and for using the tutorial.

Review comment:
       ```suggestion
   The Druid `docker-compose.yml` example uses an [environment 
file](https://docs.docker.com/compose/environment-variables/#the-env_file-configuration-option)
 to specify the complete Druid configuration, including the environment 
variables described in [Configuration](#configuration). This file is named 
`environment` by default, and must be in the same directory as the 
`docker-compose.yml` file. 
[Download](https://raw.githubusercontent.com/apache/druid/{{DRUIDVERSION}}/distribution/docker/environment)
 the example `environment` file to the directory created above. The options in 
this file work well for trying Druid and for using the tutorial.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to