clintropolis opened a new pull request #11650:
URL: https://github.com/apache/druid/pull/11650


   ### Description
   This PR adds SQL functions `MV_FILTER_ONLY` and `MV_FILTER_NONE` which will 
filter rows of multi-value string dimensions to include only or none of the a 
supplied list of values respectively.
   
   Behind the scenes, this uses a new native virtual column type, 
`ListFilteredVirtualColumn`, which is the equivalent of 
`ListFilteredDimensionSpec`, but migrated to use a `VirtualColumn` since I 
think we'd eventually like to deprecate `DimensionSpec` in favor of 
`VirtualColumn`, and also because SQL is already wired to have `VirtualColumns`.
   
   SQL planning has been lightly modified to allow non-expression based virtual 
columns to be registered alongside regular expression columns.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to