clintropolis opened a new pull request #11676: URL: https://github.com/apache/druid/pull/11676
### Description This started out as a quest to make JDBC debug level logging slightly more verbose to get a better idea of what is happening, but in the process realized that there are quite a lot of cases where we actually aren't logging any exceptions at all whenever jdbc queries fail; all that is visible is the debug logs indicate that a connection was closed and the client might get a useful error message if it is lucky, but good luck beyond that. I couldn't find an easy way to add any sort of centralized error logging for any caught exception in the `DruidAvaticaJsonHandler`, so, I added utility methods to `DruidMeta` to slightly make the 'log and throw' pattern a bit more concise. I don't love it, but at least it makes exceptions actually be logged in the broker in a lot of cases we were missing. To err on the side of caution i essentially went through and looked for places where we were throwing some exception to the wind without any obvious catcher in Druid code (hopefully there should be no duplicates). Additionally, I made router debug logs slightly more chatty, including printing query ids when used with a broker selection strategy that parses the query at the router. This log really doesn't add much, since `AsyncQueryForwardingServlet` is quite chatty already from the base class structure it picks up by being a `AsyncProxyServlet`, but does at least print some things in Druid terms I guess. This will probably fail CI because its all log messages and didn't add any tests... <hr> This PR has: - [x] been self-reviewed. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
