clintropolis commented on a change in pull request #11676:
URL: https://github.com/apache/druid/pull/11676#discussion_r707895761
##########
File path: sql/src/main/java/org/apache/druid/sql/avatica/DruidMeta.java
##########
@@ -63,7 +64,19 @@
public class DruidMeta extends MetaImpl
{
- private static final Logger log = new Logger(DruidMeta.class);
+ public static <T extends Throwable> T logFailure(T error, String message,
Object... format)
+ {
+ LOG.error(message, format);
+ return error;
+ }
+
+ public static <T extends Throwable> T logFailure(T error)
+ {
+ LOG.noStackTrace().error(error, error.getMessage());
Review comment:
Hmm, I guess I was trying to match the behavior here when logging errors
in `QueryLifecycle`, but maybe these are worth having the stack trace handy
since I guess they are only happening outside the query lifecycle so maybe more
interesting. I'm going to change it I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
