suneet-s commented on pull request #11467: URL: https://github.com/apache/druid/pull/11467#issuecomment-916605008
Thanks for the contribution @achimbab! The benchmark results look promising. I have to spend some time to understand the changes better and hope to get a review out next week. In the mean time, could you resolve the merge conflicts that exist now please. Also I skimmed the changes and noticed new SQL functions - to test that they are wired up correctly, could you add a test to one of the `CalciteQueryTest` classes - these are what I use to write "integration tests" for SQL functions so we can ensure these functions continue to work with each new release of Druid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
