[GitHub] [druid] clintropolis commented on pull request #11680: Require DATASOURCE WRITE access in SupervisorResourceFilter and TaskResourceFilter

Mon, 13 Sep 2021 00:29:39 -0700 


clintropolis commented on pull request #11680:
URL: https://github.com/apache/druid/pull/11680#issuecomment-917918247


   I missed a couple of things in my initial review, SQL queries to sys.tasks 
and sys.supervisors still use read permissions and a handful of task report 
APIs also still use read instead of write
   
   
   ![Screen Shot 2021-09-09 at 1 53 58 
PM](https://user-images.githubusercontent.com/1577461/133041439-c33ec9b2-bf3b-49f2-a4fa-beb2c356b1d6.png)
   ![Screen Shot 2021-09-09 at 1 54 08 
PM](https://user-images.githubusercontent.com/1577461/133041468-7e8d7ced-775a-4fe7-86d2-cc587bb9c4cf.png)
   
   so this change isn't quite yet complete I think. (I do still think WRITE 
makes more sense for the changes here and all of these APIs). I'm not sure if I 
missed any others, probably worth having another look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to