mghosh4 commented on a change in pull request #11554:
URL: https://github.com/apache/druid/pull/11554#discussion_r707784563
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/SingleTaskBackgroundRunner.java
##########
@@ -314,33 +317,33 @@ public TaskLocation getTaskLocation(String taskId)
}
@Override
- public long getTotalTaskSlotCount()
+ public Map<String, Long> getTotalTaskSlotCount()
{
- return 1;
+ return ImmutableMap.of(WorkerConfig.DEFAULT_CATEGORY, 1L);
Review comment:
@jihoonson yes you are correct this value is not used anywhere except
`SingleTaskBackgroundRunnerTest`. Returning 1 is probably the right thing to do
here since in a sense there is only 1 task slot. Ofcourse throwing the
exception is an option as well. I would personally tilt towards the first
option given it fits the semantics better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
