jihoonson commented on a change in pull request #11554:
URL: https://github.com/apache/druid/pull/11554#discussion_r724727761
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/SingleTaskBackgroundRunner.java
##########
@@ -314,33 +317,33 @@ public TaskLocation getTaskLocation(String taskId)
}
@Override
- public long getTotalTaskSlotCount()
+ public Map<String, Long> getTotalTaskSlotCount()
{
- return 1;
+ return ImmutableMap.of(WorkerConfig.DEFAULT_CATEGORY, 1L);
Review comment:
Hi @nikhil-ddu, can you please check my last comment above? The CI
failure seems legit as well. It failed with a compilation error like below. I
think this PR is good to go once you fix the compilation error.
```
[ERROR] COMPILATION ERROR :
[ERROR]
/home/travis/build/apache/druid/indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/SinglePhaseSubTask.java:[622,13]
constructor IngestionStatsAndErrorsTaskReportData in class
org.apache.druid.indexing.common.IngestionStatsAndErrorsTaskReportData cannot
be applied to given types;
required:
org.apache.druid.indexer.IngestionState,java.util.Map<java.lang.String,java.lang.Object>,java.util.Map<java.lang.String,java.lang.Object>,java.lang.String,boolean,long
found:
org.apache.druid.indexer.IngestionState,java.util.Map<java.lang.String,java.lang.Object>,java.util.Map<java.lang.String,java.lang.Object>,java.lang.String,boolean
reason: actual and formal argument lists differ in length
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile)
on project druid-indexing-service: Compilation failure
[ERROR]
/home/travis/build/apache/druid/indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/SinglePhaseSubTask.java:[622,13]
constructor IngestionStatsAndErrorsTaskReportData in class
org.apache.druid.indexing.common.IngestionStatsAndErrorsTaskReportData cannot
be applied to given types;
[ERROR] required:
org.apache.druid.indexer.IngestionState,java.util.Map<java.lang.String,java.lang.Object>,java.util.Map<java.lang.String,java.lang.Object>,java.lang.String,boolean,long
[ERROR] found:
org.apache.druid.indexer.IngestionState,java.util.Map<java.lang.String,java.lang.Object>,java.util.Map<java.lang.String,java.lang.Object>,java.lang.String,boolean
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
