This is an automated email from the ASF dual-hosted git repository.

cwylie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 635490d  don't throw local storage errors (#11752)
635490d is described below

commit 635490d568f89c554c6a84ef5c19d8c243859bed
Author: Vadim Ogievetsky <[email protected]>
AuthorDate: Tue Oct 5 18:49:16 2021 -0700

    don't throw local storage errors (#11752)
---
 web-console/src/utils/local-storage-keys.tsx | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/web-console/src/utils/local-storage-keys.tsx 
b/web-console/src/utils/local-storage-keys.tsx
index 5d78bb3..220a709 100644
--- a/web-console/src/utils/local-storage-keys.tsx
+++ b/web-console/src/utils/local-storage-keys.tsx
@@ -46,7 +46,11 @@ export type LocalStorageKeys = typeof LocalStorageKeys[keyof 
typeof LocalStorage
 
 export function localStorageSet(key: LocalStorageKeys, value: string): void {
   if (typeof localStorage === 'undefined') return;
-  localStorage.setItem(key, value);
+  try {
+    localStorage.setItem(key, value);
+  } catch (e) {
+    console.error('Issue setting local storage key', e);
+  }
 }
 
 export function localStorageSetJson(key: LocalStorageKeys, value: any): void {
@@ -55,7 +59,12 @@ export function localStorageSetJson(key: LocalStorageKeys, 
value: any): void {
 
 export function localStorageGet(key: LocalStorageKeys): string | undefined {
   if (typeof localStorage === 'undefined') return;
-  return localStorage.getItem(key) || undefined;
+  try {
+    return localStorage.getItem(key) || undefined;
+  } catch (e) {
+    console.error('Issue getting local storage key', e);
+    return;
+  }
 }
 
 export function localStorageGetJson(key: LocalStorageKeys): any {
@@ -70,5 +79,9 @@ export function localStorageGetJson(key: LocalStorageKeys): 
any {
 
 export function localStorageRemove(key: LocalStorageKeys): void {
   if (typeof localStorage === 'undefined') return;
-  localStorage.removeItem(key);
+  try {
+    localStorage.removeItem(key);
+  } catch (e) {
+    console.error('Issue removing local storage key', e);
+  }
 }

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to