clintropolis commented on a change in pull request #11742:
URL: https://github.com/apache/druid/pull/11742#discussion_r722491055
##########
File path: integration-tests/docker/tls/set-docker-host-ip.sh
##########
@@ -24,7 +24,7 @@ fi
if [ -z "$DOCKER_HOST_IP" ]; then
# Another Mac specific way, when the machine isn't able to resolve its own
name
- DOCKER_HOST_IP="$(ifconfig | fgrep 'inet ' | fgrep -v 127.0.0.1 | awk
'{print $2}')"
+ DOCKER_HOST_IP="$(ifconfig | fgrep 'inet ' | fgrep -v 127.0.0.1 | awk
'{print $2}' | tail -n1)"
Review comment:
>The build script should pick any one of local network addresses as
DOCKER_HOST_IP. And as a fix, the last IP address returned by ifconfig command
is picked.
hmm, a bit confused, if the vpn addresses are last in the list, why `tail
-n1` here instead of `head -n1` or do we want to use the vpn address as the
docker ip? When i tested this on my mac it gave me my vpn address when using
`tail` but my local address when using `head`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
