FrankChen021 commented on a change in pull request #11742:
URL: https://github.com/apache/druid/pull/11742#discussion_r723795134
##########
File path: integration-tests/docker/tls/set-docker-host-ip.sh
##########
@@ -24,7 +24,7 @@ fi
if [ -z "$DOCKER_HOST_IP" ]; then
# Another Mac specific way, when the machine isn't able to resolve its own
name
- DOCKER_HOST_IP="$(ifconfig | fgrep 'inet ' | fgrep -v 127.0.0.1 | awk
'{print $2}')"
+ DOCKER_HOST_IP="$(ifconfig | fgrep 'inet ' | fgrep -v 127.0.0.1 | awk
'{print $2}' | tail -n1)"
Review comment:
I think both `head` or `tail` is ok, because either a local network
address or a VPN address is a usable address. The reason why tail is used is
because it's consistent with the line 22 in this file where a `tail` command is
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
