jon-wei opened a new pull request #11788: URL: https://github.com/apache/druid/pull/11788
When a batch task is added to the TaskQueue but its lock is revoked (such as when a streaming task gets data for a conflicting time interval), the isReady method currently returns false, and the task will never become ready, leading to the task remaining in a WAITING state forever. This PR causes a revoked lock to throw an exception, causing the task with the revoked lock to fail. The TimeChunkLockTryAcquireAction has been adjusted to return the LockResult instead of the Lock or `null` so that the task's `isReady` method can check the revocation status. This PR has: - [x] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
