jon-wei commented on a change in pull request #11788:
URL: https://github.com/apache/druid/pull/11788#discussion_r727662536
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##########
@@ -404,6 +405,9 @@ protected boolean tryTimeChunkLock(TaskActionClient client,
List<Interval> inter
if (lock == null) {
return false;
}
+ if (lock.isRevoked()) {
Review comment:
Hm, I had similar concerns, I think we're good:
for `TaskLockbox.tryLock` called by itself:
- `SegmentAllocateAction` already checks `isRevoked()` and `isOk()` on the
`LockResult`
- `SegmentLockTryAcquireAction` usages check `isOk()` on the result
- `TimeChunkLockTryAcquireAction` usages are adjusted in this PR
for `TaskLockbox.lock` calls:
- `SegmentLockAcquireAction` usages check `isOk()` on the result
- `TimeChunkLockAcquireAction` usages are adjusted in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
