pjain1 commented on a change in pull request #11309:
URL: https://github.com/apache/druid/pull/11309#discussion_r739854428
##########
File path:
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java
##########
@@ -369,7 +392,7 @@ private void addSegments(Collection<DataSegment> segments,
final DataSegmentChan
numSegments,
segment.getId()
);
- loadSegment(segment, callback, config.isLazyLoadOnStart());
+ loadSegment(segment, callback, config.isLazyLoadOnStart(),
loadSegmentsIntoPageCacheOnBootstrapExec);
Review comment:
I understand your point I am just worried that when a historical is
warming up the query performance at that time will be worse than performance
after usual boot up as its already doing disk reads for warming up and doing
more disk reads for serving query.
Can we introduce a flag to enable synchronous warm up which when enabled
historical only announces itself after everything is read once. When warm up is
enabled default behaviour will be async as in this PR but can be changed to
sync warm up when boot up time is not a concern. How does this sound to you ?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
