pjain1 commented on a change in pull request #11309:
URL: https://github.com/apache/druid/pull/11309#discussion_r783866038



##########
File path: 
server/src/main/java/org/apache/druid/segment/loading/SegmentLocalCacheManager.java
##########
@@ -95,6 +104,14 @@ public SegmentLocalCacheManager(
     this.locations = locations;
     this.strategy = strategy;
     log.info("Using storage location strategy: [%s]", 
this.strategy.getClass().getSimpleName());
+
+    if (this.config.getNumThreadsToLoadSegmentsIntoPageCacheOnDownload() != 0) 
{

Review comment:
       nit: Should add validation for negative values




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to