kfaraz commented on a change in pull request #11848:
URL: https://github.com/apache/druid/pull/11848#discussion_r741665919
##########
File path:
core/src/main/java/org/apache/druid/indexer/partitions/SingleDimensionPartitionsSpec.java
##########
@@ -21,83 +21,52 @@
import com.fasterxml.jackson.annotation.JsonCreator;
-import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonValue;
import com.google.common.annotations.VisibleForTesting;
-import com.google.common.base.Preconditions;
-import org.apache.druid.indexer.Checks;
-import org.apache.druid.indexer.Property;
import javax.annotation.Nullable;
-import javax.validation.constraints.NotNull;
import java.util.Collections;
-import java.util.List;
-import java.util.Objects;
+import java.util.HashMap;
+import java.util.Map;
/**
* Partition a segment by a single dimension.
*/
-public class SingleDimensionPartitionsSpec implements
DimensionBasedPartitionsSpec
+public class SingleDimensionPartitionsSpec extends MultiDimensionPartitionsSpec
{
public static final String NAME = "single_dim";
static final String OLD_NAME = "dimension"; // for backward compatibility
- private static final String PARITION_DIMENSION = "partitionDimension";
- private static final String MAX_PARTITION_SIZE = "maxPartitionSize";
+ private static final String PARTITION_DIMENSION = "partitionDimension";
+
private static final String FORCE_GUARANTEED_ROLLUP_COMPATIBLE = "";
- private final Integer targetRowsPerSegment;
- private final Integer maxRowsPerSegment;
private final String partitionDimension;
- private final boolean assumeGrouped;
-
- // Values for these fields are derived from the one above:
- private final int resolvedMaxRowPerSegment;
@JsonCreator
public SingleDimensionPartitionsSpec(
Review comment:
Done. Thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
