kfaraz commented on a change in pull request #11848: URL: https://github.com/apache/druid/pull/11848#discussion_r741889729
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/distribution/ArrayOfStringTuplesSerDe.java ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.common.task.batch.parallel.distribution; + +import org.apache.datasketches.ArrayOfItemsSerDe; +import org.apache.datasketches.ArrayOfStringsSerDe; +import org.apache.datasketches.memory.Memory; +import org.apache.datasketches.memory.WritableMemory; +import org.apache.datasketches.memory.internal.UnsafeUtil; +import org.apache.druid.data.input.StringTuple; + +/** + * Serde for {@link StringTuple}. + * + * Implementation similar to {@link ArrayOfStringsSerDe}. + */ +public class ArrayOfStringTuplesSerDe extends ArrayOfItemsSerDe<StringTuple> +{ + private static final ArrayOfStringsSerDe STRINGS_SERDE = new ArrayOfStringsSerDe(); + + @Override + public byte[] serializeToByteArray(StringTuple[] items) + { + int length = 0; + final byte[][] itemsBytes = new byte[items.length][]; + for (int i = 0; i < items.length; i++) { + itemsBytes[i] = STRINGS_SERDE.serializeToByteArray(items[i].toArray()); + length += itemsBytes[i].length + Integer.BYTES; + length += items[i].size() + Integer.BYTES; Review comment: Fixed. Thanks! ########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialRangeSegmentGenerateTask.java ########## @@ -92,20 +92,20 @@ public PartialRangeSegmentGenerateTask( this.intervalToPartitions = intervalToPartitions; } - private static String getPartitionDimension(ParallelIndexIngestionSpec ingestionSpec) + private static List<String> getPartitionDimensions(ParallelIndexIngestionSpec ingestionSpec) { PartitionsSpec partitionsSpec = ingestionSpec.getTuningConfig().getPartitionsSpec(); Preconditions.checkArgument( - partitionsSpec instanceof SingleDimensionPartitionsSpec, + partitionsSpec instanceof MultiDimensionPartitionsSpec, "%s partitionsSpec required", Review comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
