clintropolis commented on a change in pull request #11853:
URL: https://github.com/apache/druid/pull/11853#discussion_r744014441
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/ExpressionLambdaAggregator.java
##########
@@ -89,4 +96,88 @@ public void close()
{
// nothing to close
}
+
+ /**
+ * Tries to mimic the byte serialization of {@link Types} binary methods use
to write expression values for the
+ * {@link ExpressionLambdaBufferAggregator} in an attempt to provide
consistent size limits when using the heap
+ * based algorithm.
+ */
+ @VisibleForTesting
+ public static void estimateAndCheckMaxBytes(ExprEval eval, int maxSizeBytes)
Review comment:
if I do the `TypeStrategy` thing mentioned in the other comment, then
size estimation will be pushed there which seems like a more appropriate place.
I put it here for now because this is the only caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
