clintropolis commented on a change in pull request #11853:
URL: https://github.com/apache/druid/pull/11853#discussion_r744020052
##########
File path: core/src/main/java/org/apache/druid/math/expr/ExprEval.java
##########
@@ -1129,6 +1032,10 @@ public String asString()
public boolean isNumericNull()
{
if (isScalar()) {
+ if (arrayType.getElementType().is(ExprType.STRING)) {
+ Number n = computeNumber((String) getScalarValue());
Review comment:
ah yeah, I guess i lost the caching the separate string array impl had.
it is probably worth considering adding back, though many of the expression
selectors cache their result based on the current offset so that they don't
need to recompute the expression when getting the same row
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
