clintropolis opened a new pull request #11887: URL: https://github.com/apache/druid/pull/11887
### Description #11650 missed adding JSON type info for `ListFilteredVirtualColumn`, which results in failure when actually trying to use it. This was my bad - it had serde tests, but not serde as a part of a query, so there was a blind spot. I've added a JSON serialization round trip as part of validation in `BaseCalciteQueryTest` to try to prevent this from happening again. I suspect that not everything on every query implements `equals` fully, because directly comparing the round-tripped serialized query against the expected query resulted in a failure, but comparing the string of the round tripped query against the string of the expected query does seem to pass, so went with that for now. All of the `MV_FILTER_*` tests failed prior to this change, so it should at least help. <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [x] been self-reviewed. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
