clintropolis commented on pull request #11887: URL: https://github.com/apache/druid/pull/11887#issuecomment-963540318
I ended up getting the round trip JSON serde tests working by just creating a fresh `ObjectMapper`, which is sad, and requires subclasses of `BaseCalciteQueryTest` to override a new method it has, `getJacksonModules` which can add the jackson modules to both the static shared mapper and the mapper created specifically for the round trip tests. I'm unsure if this is worth the trouble, but it does seem useful still to catch things like this so I think the answer is barely yes. I still don't quite understand why the static object mapper doesn't work correctly when running the datasketches extension calcite tests. Examining the mapper in the debugger I see that all of the subtypes are present, but it still serializes to string incorrectly with the class name instead of the type names specified in `SketchModule` and `DoublesSketchModule`, only `HllSketchModule` works correctly (it runs first). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
