abhishekagarwal87 commented on a change in pull request #11895:
URL: https://github.com/apache/druid/pull/11895#discussion_r745480177



##########
File path: 
processing/src/main/java/org/apache/druid/query/metadata/metadata/ColumnAnalysis.java
##########
@@ -47,6 +50,7 @@ public static ColumnAnalysis error(String reason)
 
   @JsonCreator
   public ColumnAnalysis(
+      @JsonProperty("typeSignature") ColumnType typeSignature,

Review comment:
       
https://github.com/apache/druid/pull/11895/files#diff-5aa1494dc5a13e82654e42ce8cdb3cb628c95233f8828312b3ede40dac1b8544R156
 - shall this be modified to pick the one if the other is null instead of 
throwing an error. I am throwing darts in the dark here so please ignore if 
this is not really a problem :) 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to