gianm commented on pull request #11917: URL: https://github.com/apache/druid/pull/11917#issuecomment-971059535
After further reflection I'd like to advocate for a policy that backward compatibility and longer deprecation periods are preferred when they aren't too disruptive, but also that we shouldn't be hesitant to break compatibility more quickly if that enables us to make some substantial improvement. In this case, I don't think a substantial improvement is being blocked, so I would stick with the change in this PR. > On the subject of this PR only impacting a single release, I'm not entirely sure that is true either unless we just leave these functions named as they are renamed in this PR - getColumnType and getFinalizedColumnType. Faced with this fact I would say let's stick with getColumnType and getFinalizedColumnType, rather than planning to change them back to getType and getFinalizedType. It simplifies our lives (less work, less churn) and either name seems equally ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
