gianm commented on a change in pull request #11917:
URL: https://github.com/apache/druid/pull/11917#discussion_r751776857
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/AggregatorFactory.java
##########
@@ -219,7 +220,13 @@ public AggregatorFactory
getMergingFactory(AggregatorFactory other) throws Aggre
*
* Refer to the {@link ColumnType} javadocs for details on the implications
of choosing a type.
*/
- public abstract ColumnType getType();
+ public ColumnType getColumnType()
+ {
+ if (getType() == ValueType.COMPLEX) {
+ return ColumnType.ofComplex(getComplexTypeName());
Review comment:
getComplexTypeName wouldn't necessarily have been implemented for
aggregators that aren't ingestible, so this should catch
UnsupportedOperationException and treat it as an unknown complex type. (Or have
the default impl of getComplexTypeName return null and check for null here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
