LakshSingla opened a new pull request #11968:
URL: https://github.com/apache/druid/pull/11968
### Description
Issue:
`DruidRexExecutor` while reducing Arrays, specially numeric arrays, doesn't
convert the value from ExprResult's type to BigDecimal, which causes
`makeLiteral` to cast the values. Also, if NaN or Infinite values are present
in the array, the error is a generic `NumberFormatException`. For example:
`SELECT ARRAY[1.11, 2.22]` returns [1, 2]
`SELECT SQRT(-1)` throws a generic `NumberFormatException` instead of `IAE`
This PR introduces change to cast the numeric values to `BigDecimal` since
Calcite's library understands that easily, and doesn't perform casts.
<hr>
##### Key changed/added classes in this PR
* `DruidRexExecutor#reduce()`
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
