suneet-s commented on a change in pull request #11922:
URL: https://github.com/apache/druid/pull/11922#discussion_r754590267
##########
File path:
server/src/test/java/org/apache/druid/server/coordinator/duty/NewestSegmentFirstPolicyTest.java
##########
@@ -1144,7 +1149,123 @@ public void
testIteratorReturnsSegmentsAsSegmentsWasCompactedAndHaveDifferentDim
130000,
new Period("P0D"),
null,
- new UserCompactionTaskDimensionsConfig(null)
+ new UserCompactionTaskDimensionsConfig(null),
+ null
+ )),
+ ImmutableMap.of(DATA_SOURCE, timeline),
+ Collections.emptyMap()
+ );
+ // No more
+ Assert.assertFalse(iterator.hasNext());
+ }
+
+ @Test
+ public void
testIteratorReturnsSegmentsAsSegmentsWasCompactedAndHaveDifferentFilter()
throws Exception
+ {
+ NullHandling.initializeForTests();
Review comment:
nit: I think this should be done at the test class level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
