rohangarg commented on a change in pull request #11949:
URL: https://github.com/apache/druid/pull/11949#discussion_r754998229
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/first/DoubleFirstAggregatorFactory.java
##########
@@ -256,20 +259,28 @@ public String getFieldName()
return fieldName;
}
+ @JsonProperty
+ public String getTimeColumn()
+ {
+ return timeColumn;
+ }
+
@Override
public List<String> requiredFields()
{
- return Arrays.asList(ColumnHolder.TIME_COLUMN_NAME, fieldName);
+ return Arrays.asList(timeColumn, fieldName);
}
@Override
public byte[] getCacheKey()
{
byte[] fieldNameBytes = StringUtils.toUtf8(fieldName);
+ byte[] timeColumnBytes = StringUtils.toUtf8(timeColumn);
Review comment:
yup, moved the aggs to `CacheKeyBuilder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
