LakshSingla commented on a change in pull request #11949:
URL: https://github.com/apache/druid/pull/11949#discussion_r752561204
##########
File path:
processing/src/test/java/org/apache/druid/query/aggregation/first/FloatFirstAggregationTest.java
##########
@@ -91,7 +95,25 @@ public void testDoubleFirstAggregator()
}
@Test
- public void testDoubleFirstBufferAggregator()
+ public void testFloatFirstAggregatorWithTimeColumn()
+ {
+ Aggregator agg = new FloatFirstAggregatorFactory("billy", "nilly",
"customTime").factorize(colSelectorFactory);
+
+ aggregate(agg);
Review comment:
nit: Should this be done in a loop?
##########
File path: docs/querying/aggregations.md
##########
@@ -143,101 +143,111 @@ Note that queries with first/last aggregators on a
segment created with rollup e
#### `doubleFirst` aggregator
-`doubleFirst` computes the metric value with the minimum timestamp or 0 in
default mode, or `null` in SQL-compatible mode if no row exists.
+`doubleFirst` computes the metric value with the minimum value for time column
or 0 in default mode, or `null` in
Review comment:
nit: Unnecessary line break
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
