abhishekagarwal87 commented on a change in pull request #11978:
URL: https://github.com/apache/druid/pull/11978#discussion_r755027315
##########
File path:
extensions-core/druid-basic-security/src/main/java/org/apache/druid/security/basic/authentication/validator/LDAPCredentialsValidator.java
##########
@@ -213,8 +221,10 @@ SearchResult getLdapUserObject(BasicAuthLDAPConfig
ldapConfig, DirContext contex
boolean validatePassword(BasicAuthLDAPConfig ldapConfig, LdapName userDn,
char[] password)
{
InitialDirContext context = null;
+ ClassLoader currentClassLoader =
Thread.currentThread().getContextClassLoader();
Review comment:
The thought did cross my mind. I didn't want to tinker with the
try/catch flow. I also don't know what the impact of opening
`InitialDirContext` while one is already open, will be. Probably none. This
change felt safer to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
