LakshSingla commented on pull request #11908: URL: https://github.com/apache/druid/pull/11908#issuecomment-977877937
Thanks for the comment @vogievetsky 1. As mentioned by @clintropolis, Gian's PR should make the RowSignature serializable. However, I have added a temporary `JsonValue` method till then which will help the Jackson serialize it, till those changes get merged. I have kept the output of my change is similar to Gian's change, so ideally no testcases need to updated, and the `DruidPlanner's` code also works without any tweaks. (This would introduce some merge conflicts in `RowSignature` and `RowSignatureTest` in https://github.com/apache/druid/pull/11959, but resolving it should be simple - discard the older changes for the new ones. 2. I haven't tested it out, but it should break the console output. I have changed the default behavior to show the __legacy__ output (i.e. the original behaviour), and therefore, no breaking changes are introduced in the PR. There is no requirement of updating the UI code immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
