LakshSingla commented on a change in pull request #11908:
URL: https://github.com/apache/druid/pull/11908#discussion_r756406517



##########
File path: docs/configuration/index.md
##########
@@ -1827,7 +1827,7 @@ The Druid SQL server is configured through the following 
properties on the Broke
 |`druid.sql.planner.metadataSegmentCacheEnable`|Whether to keep a cache of 
published segments in broker. If true, broker polls coordinator in background 
to get segments from metadata store and maintains a local cache. If false, 
coordinator's REST API will be invoked when broker needs published segments 
info.|false|
 |`druid.sql.planner.metadataSegmentPollPeriod`|How often to poll coordinator 
for published segments list if `druid.sql.planner.metadataSegmentCacheEnable` 
is set to true. Poll period is in milliseconds. |60000|
 |`druid.sql.planner.authorizeSystemTablesDirectly`|If true, Druid authorizes 
queries against any of the system schema tables (`sys` in SQL) as 
`SYSTEM_TABLE` resources which require `READ` access, in addition to 
permissions based content filtering.|false|
-|`druid.sql.planner.useLegacyDruidExplain`|If true, `EXPLAIN PLAN FOR` will 
return the explain plan in legacy format, else it will return a JSON 
representation of the native queries the given SQL statement translates to. It 
can be overridden per query with `useLegacyDruidExplain` context key.|false|
+|`druid.sql.planner.useLegacyDruidExplain`|If true, `EXPLAIN PLAN FOR` will 
return the explain plan in legacy format, else it will return a JSON 
representation of the native queries the given SQL statement translates to. It 
can be overridden per query with `useLegacyDruidExplain` context key.|true|

Review comment:
       If in the future, the newer explain plan is to be used, then I think 
`useLegacyDruidExplain` would work better, since we won't have to change the 
feature flag then. But it does look weird right now, since it hasn't been 
deprecated yet. I am fine with keeping it either way. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to