paul-rogers commented on pull request #11822:
URL: https://github.com/apache/druid/pull/11822#issuecomment-979451080
Looks like the build is failing due to incomplete tests. In file
`ParallelMergeCombiningSequence.java`, we replaced this line:
```java
out.offer(ResultBatch.TERMINAL);
```
With this one:
```java
out.offer((ParallelMergeCombiningSequence.ResultBatch<T>)
ResultBatch.TERMINAL);
```
Which is clearly only a compile-time change (to remove a warning.) Yet, the
build fails with this error:
```text
Diff coverage statistics:
------------------------------------------------------------------------------
| lines | branches | functions | path
------------------------------------------------------------------------------
| 0% (0/1) | 100% (0/0) | 100% (0/0) |
org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
------------------------------------------------------------------------------
...
ERROR: Insufficient line coverage of 0% (0/1). Required 50%.
```
This error prevents the Stage 2 tests from running.
It seems we've got a situation where we can't clean up warnings in code
until we figure out how to fully unit test the code. While having tests is a
*Good Thing*, it seems we've wrapped ourselves around the axel because we
didn't require tests when the code was written, but we do require someone else
to write the tests to clean up warnings.
Suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
