paul-rogers commented on a change in pull request #11828:
URL: https://github.com/apache/druid/pull/11828#discussion_r759636434
##########
File path: server/src/main/java/org/apache/druid/query/RetryQueryRunner.java
##########
@@ -157,7 +156,11 @@ public void cleanup(RetryingSequenceIterator iterFromMake)
throw new ISE("Failed to check missing segments due to missing responses
from [%d] servers", remainingResponses);
}
- final Object maybeMissingSegments =
context.get(ResponseContext.Key.MISSING_SEGMENTS);
+ // TODO: the sender's response may contain a truncated list of missing
segments.
+ // Truncation is aggregated in the response context given as a parameter.
+ // Check the getTruncated() value: if true, then the we don't know the
full set of
+ // missing segments.
Review comment:
Issue has been filed: https://github.com/apache/druid/issues/11811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
