clintropolis commented on a change in pull request #11923:
URL: https://github.com/apache/druid/pull/11923#discussion_r765465153
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidLogicalValuesRule.java
##########
@@ -110,6 +111,13 @@ static Object getValueFromLiteral(RexLiteral literal,
PlannerContext plannerCont
case SMALLINT:
case INTEGER:
case BIGINT:
+ // Safegaurd in case the internal implementaion of the RexLiteral for
numbers change
+ Object maybeBigDecimalImpl = literal.getValue();
+ if (maybeBigDecimalImpl instanceof BigDecimal) {
+ return ((BigDecimal) maybeBigDecimalImpl).longValue();
+ }
+ // This might return incorrect value if the literal was created from
float.
+ // For example, representation of the form 123.0 can return 1230
Review comment:
given that all of our calls to `getValueAs` are already within a case
statement on the literal type, it seems redundant to me to use `getValueAs`,
which is going to do another case statement on typeName instead of
type.getTypeName.
Maybe we should just do `literal.getValue` instead of `literal.getValueAs`.
Strings seem like always `NlsString`, numeric types will always be
`BigDecimal`, so we can just convert to float, double, or long as appropriate.
```
...
case VARCHAR:
return ((NlsString) literal.getValue()).getValue();
case FLOAT:
return ((BigDecimal) literal.getValue()).floatValue();
case DOUBLE:
case REAL:
case DECIMAL:
return ((BigDecimal) literal.getValue()).doubleValue();
case TINYINT:
case SMALLINT:
case INTEGER:
case BIGINT:
return ((BigDecimal) literal.getValue()).longValue();
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
