abhishekagarwal87 commented on a change in pull request #11923:
URL: https://github.com/apache/druid/pull/11923#discussion_r765549260
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidLogicalValuesRule.java
##########
@@ -110,6 +111,13 @@ static Object getValueFromLiteral(RexLiteral literal,
PlannerContext plannerCont
case SMALLINT:
case INTEGER:
case BIGINT:
+ // Safegaurd in case the internal implementaion of the RexLiteral for
numbers change
+ Object maybeBigDecimalImpl = literal.getValue();
+ if (maybeBigDecimalImpl instanceof BigDecimal) {
+ return ((BigDecimal) maybeBigDecimalImpl).longValue();
+ }
+ // This might return incorrect value if the literal was created from
float.
+ // For example, representation of the form 123.0 can return 1230
Review comment:
this makes more assumptions about how that code is written inside the
library. Calling `literal.getValueAs(BigDecimal.class)` makes the intention
explicit that `BigDecimal` is the type we want. Current ways seem future-proof
to unexpected changes in the calcite library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
