vogievetsky opened a new pull request #12085: URL: https://github.com/apache/druid/pull/12085
At a high level this PR adds a DiffDialog to visualize the change in supervisor specs between edits. This PR also upgrades the [Ace editor](https://ace.c9.io/) (the main code editor for all the JSONs and SQLs). This is done by upgrading to the latest version or `react-ace` which in turn changes how the Ace editor itself is imported from using `brace` to using `ace-builds` (see the [readme of react-ace](https://github.com/securingsincity/react-ace) for more details on why). New Diff view:  Updated auto suggestion styling to be more on brand:  So here are the changes that generate the diffs: - Switched from `brace` to `ace-builds` which generates a large number of dependent package and license changes - Updated to new ReactAce and went everywhere updating the APIs (there are many changes on the JS and the CSS endpoints) - Normalized the capitalization and spelling of all the `describe` labels - Pulled out all the Ace editor styles into a single file `ace.scss` This PR has: - [x] been self-reviewed. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
