themarcelor opened a new pull request #12116:
URL: https://github.com/apache/druid/pull/12116
### Description
This is a small but valuable change that augments the existing jetty logger
instruction to present the HTTP response code.
This is extremely helpful to calculate the SR (Success Rate) based on the
percentage of non-http-5xx requests, which powers SLO/SLA definitions and
alerting (with a log indexing / metrics scrapping/exporting mechanism).
Please provide some handholding around testing, what is the best way to
compile & dockerize this change so I can test this in my k8s cluster?
##### Key changed/added classes in this PR
* `JettyRequestLog.java`
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [x] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
