xvrl commented on a change in pull request #12096:
URL: https://github.com/apache/druid/pull/12096#discussion_r779800261
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ZkWorker.java
##########
@@ -63,6 +67,25 @@ public ZkWorker(Worker worker, PathChildrenCache
statusCache, final ObjectMapper
this.statusCache = statusCache;
this.cacheConverter = (ChildData input) ->
JacksonUtils.readValue(jsonMapper, input.getData(),
TaskAnnouncement.class);
+ this.taskIdExtractor = createTaskIdExtractor(jsonMapper);
+ }
+
+ static java.util.function.Function<ChildData, String>
createTaskIdExtractor(final ObjectMapper jsonMapper)
+ {
+ return (ChildData input) -> {
+ try (JsonParser parser =
jsonMapper.getFactory().createParser(input.getData())) {
+ while (parser.nextToken() != JsonToken.END_OBJECT) {
+ if ("id".equals(parser.getCurrentName())) {
Review comment:
it would probably be worthwhile to put some safeguards to ensure we
don't accidentally extract an "id" field from one of the nested objects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
