jasonk000 commented on a change in pull request #12096:
URL: https://github.com/apache/druid/pull/12096#discussion_r779950249
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/worker/TaskAnnouncement.java
##########
@@ -35,6 +35,8 @@
*/
public class TaskAnnouncement
{
+ public static final String TASK_ID_KEY = "id";
Review comment:
In my view it's closer to being in the 'model' aka in the
`TaskAnnouncement` record, since we want the `taskId`. It should also act as a
prompt so that if the `TaskAnnouncement` field is changed at any point then
compiler will flag an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
