clintropolis commented on a change in pull request #12078:
URL: https://github.com/apache/druid/pull/12078#discussion_r780210083
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/CalciteArraysQueryTest.java
##########
@@ -143,54 +144,6 @@ public void
testSelectNonConstantArrayExpressionFromTable() throws Exception
);
}
- @Test
- public void testSelectNonConstantArrayExpressionFromTableForMultival()
throws Exception
Review comment:
heh, i wrote this test originally to document moderately strange current
behavior. This PR changes the behavior of `array` constructor function to no
longer "map" multi-value string inputs and instead treat them as arrays, so it
should probably be repurposed to test whatever the new behavior should be
probably
The map behavior was not very intuitive, since it would make a nested array
where the elements are single element arrays from the multi-value string, so
idk that it needs preserved.
We might want to consider making use of a multi-value string inside of the
array constructor an error, since i'm not sure there is an intuitive behavior
because it is ambiguous whether the user is acknowledging the column as a
multi-value, or doesn't know and thinks it single valued, which most of the
other functions don't have this ambiguity, though it probably doesn't need to
be changed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
