cryptoe commented on pull request #12078:
URL: https://github.com/apache/druid/pull/12078#issuecomment-998784656


   >     1. Would this work also for a VirtualColumn which produces a 
multi-value? Specifically, VirtualColumn of type "mv-filtered".
    Is it possible to share a sample Q here. I am trying to understand the use 
case here. Do you want to group by on array<array> ?
    
https://github.com/apache/druid/pull/12078/files#diff-8bc53aec44924e671b3c6f6f34c6f0c499f873d9000649c47c237444707aea4bR975
 . This PR does support virtual col's .
   
   
   >     2. We needed the capability in this PR, but since it was missing we 
created another string dimension during ingestion, which holds the values of 
the MV column as a simple string. We then used that extra column in our GROUP 
BY, to achieve the same functionality as this PR. Do you think that your method 
would be comparable in performance?
   
   If the original string dimension is of low cardinality, then IMHO this 
implementation will be slightly more performant with regards to memory usage 
across the historical's, brokers as we are doing optimizations on the way we 
lookup.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to